Proposal for v2. #120
Merged
Proposal for v2. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insecure Network Communication (1)
More info on how to fix Insecure Network Communication in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
===========================================
+ Coverage 68.23% 97.81% +29.57%
===========================================
Files 12 4 -8
Lines 362 548 +186
===========================================
+ Hits 247 536 +289
+ Misses 112 9 -103
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ontext shuts down the registration just like calling Stop().
piccione99
reviewed
Aug 29, 2023
- Add a required url for the webhook url. The original address that
appeared to be the right url was the address of the requester, not the
target.
- Fix a race condition where sending an update to the goroutine can
cause a deadlock. Instead of sending the signal inside a mutex, send
it via a separate go routine that can recover from a panic if the
channel happens to be closed while it is waiting.
- Fix the token interface so it's just that; using the Token interface
not the literal token{}.
This was referenced Aug 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.