Cleanup/normalize coding style #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxamin
force-pushed
the
cleanup/normalize-coding-style
branch
from
24369f0 to
1bf9577
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes coding style across tests, source code, docs, and configuration, focusing on:
- Converting string literals to single quotes and updating to f-strings
- Modernizing calls (e.g.,
super(), exception chaining) - Replacing Flake8/Black/isort setup with Ruff and updating CI configurations
Reviewed Changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/… | Normalized quotes, docstrings, and super() calls |
| src/xmlsec/constants.pyi | Consolidated imports for Final and NamedTuple |
| setup.py | Bumped python_requires, switched to f-strings, chained exceptions |
| setup.cfg, pyproject.toml | Removed old flake8/isort settings, added Ruff config |
| .github/workflows/*.yml | Updated concurrency expressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.