Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NUnit4 #40

Closed
drjameshouse opened this issue Jan 25, 2024 · 4 comments
Closed

Support for NUnit4 #40

drjameshouse opened this issue Jan 25, 2024 · 4 comments
Milestone

Comments

@drjameshouse
Copy link

drjameshouse commented Jan 25, 2024

When updating to use NUnit 4.0.1 the following exception occurs:
System.TypeLoadException : Method 'get_Description' in type 'Org.XmlUnit.Constraints.CompareConstraint' from assembly 'xmlunit-nunit3-constraints, Version=2.9.2.240, Culture=neutral, PublicKeyToken=e7d7e3088fd452f6' does not have an implementation.

NUnit4 requires constraints to have a Description getter.

@bodewig
Copy link
Member

bodewig commented Jan 26, 2024

I haven't even been aware there is an NUnit 4.x, yet. Thanks for the heads up. This should probably be listed as breaking change over at nunit.org.

@mingyaulee
Copy link

From what I understand, in NUnit3 it was a virtual property and now it is abstract. Can we just declare an override for the virtual Description property so that it will be compatible with NUnit4?

@bodewig
Copy link
Member

bodewig commented Aug 7, 2024

sorry, I've pushed #41 to a branch a while ago and was distracted by the CI failing again, which ha become a real nuisance. Yes I believe that's all that is required, I'll try to push out a new release soonish.

bodewig added a commit that referenced this issue Aug 8, 2024
@bodewig bodewig added this to the 2.10.0 milestone Aug 8, 2024
@bodewig bodewig closed this as completed Aug 8, 2024
@bodewig
Copy link
Member

bodewig commented Aug 8, 2024

I've just published 2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants