Preparing for NUnit 3: Switch from ExpectedException attribute to Ass… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto its own file This is the only part of the test code, that needs to be changed for NUnit3, the actual tests can be shared.
…nt tests, instead just add a link to TestResources.cs
…XMLUnit.Constraints.Test
|
Ok - I've updated the PR. There's now a xmlunit-nunit2-contstraints for NUnit 2.6.4. |
|
Thanks! I may need a few days to review things, but fully intend to merge this PR before cutting alpha-03. |
|
Great! Take your time! |
|
Thanks a lot. I've renamed the constraints project to have NUnit 3 in its name, just to make things explicit. |
|
Cool! And I have to thank you! Thanks to xmlunit.net all my pesky unit tests for xml output actually became readable :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, here's a new pull request with just the commit to prepare for NUnit 3 which still is compatible with NUnit2.
I'll send a separate PR with XMLUnit.NUnit3.Constraints as soon as I've done this.