Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexagonal Architecture tests are failing #278

Closed
sfgvieira opened this issue Oct 31, 2024 · 3 comments
Closed

Hexagonal Architecture tests are failing #278

sfgvieira opened this issue Oct 31, 2024 · 3 comments
Assignees
@odrotbohm
Labels
module: archunit Archunit rules type: bug Bug
Milestone
0.24

Comments

@sfgvieira
Copy link

On version 0.21.0 all tests in JMoleculesHexagonalRulesTest.java pass, however if you upgrade to any of the newer versions they fail.

Image
@odrotbohm
Copy link
Member

Any chance you provide a reproducer? You don't seem to use the jMolecules ArchUnit verifications?

@odrotbohm odrotbohm self-assigned this Nov 5, 2024
@odrotbohm odrotbohm added type: bug Bug module: archunit Archunit rules labels Nov 5, 2024
@sfgvieira
Copy link
Author

sfgvieira commented Nov 5, 2024 •
edited
Loading

Hi @odrotbohm,
Just run (manually, with IntelliJ for example) the tests in jmolecules-archunit/src/test/java/org/jmolecules/archunit/JMoleculesHexagonalRulesTest.java from master or any tag after 0.21.0 and you will see it failing.
If I do a mvn clean install I see that these tests are not executed.

odrotbohm added a commit that referenced this issue Nov 6, 2024
@odrotbohm
GH-278 - Fix verifications for Hexagonal Architecture.
c0d879b 
The introduction of the StereotypeLookup broke the verifications for Hexagonal Architecture. We properly setup the annotation lookups and rely on the meta-annotations (@PORT, @adapter) being present at runtime. We still have to investigate why the integration tests do not get executed during a Maven build.
@odrotbohm
Copy link
Member

I'm still investigating why the nested test classes don't get executed during a build. That said, I've pushed a fix for the actual verification. Note that full detection of meta-annotations (@Port, @Adapter) will require an upgrade to jMolecules 1.10 (currently only available in snapshots). If you stick to the concrete ones, you should be good on the currently compiled against 1.8.

Would you mind giving the snapshots a try?

odrotbohm added a commit that referenced this issue Nov 20, 2024
@odrotbohm
GH-278 - Configure Surefire to not exclude nested classes.
a4a397d
@odrotbohm odrotbohm added this to the 0.24 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: archunit Archunit rules type: bug Bug
Projects
None yet
Milestone
0.24
Development

No branches or pull requests
2 participants
@odrotbohm @sfgvieira