Make spawnPipe to use system's locale encoding #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function named spawnPipeWithNoEncoding for people who might want to use binary handles. Fixes xmonad#338
|
Makes sense to me. |
2 tasks
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
Sep 8, 2020
This update, along with a recent change in xmonad-contrib, fixes the handling of unicode characters piped from xmonad to xmobar, allowing me to use a fancy dot · to indicate when the layout has been toggled to fullscreen. xmonad/xmonad-contrib#346 https://github.com/jaor/xmobar/pull/482
|
This unfortunately breaks many configs that use spawnPipe and dynamicLogString together, because dynamicLogString unfortunately expects a binary handle and encodes its output as utf8, so this then results in double-utf8-encoded output. See #338 (comment), let's continue the discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function named spawnPipeWithNoEncoding for people who might want
to use binary handles.
Fixes #338
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfile