(wip) Refactor EWMH window activation #399

liskin · 2020-11-05T00:47:31Z

Description

Work in progress on #396.

Checklist

I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the CHANGES.md file
I updated the XMonad.Doc.Extending file (if appropriate)

liskin · 2021-01-25T23:30:34Z

(test failures expected, we need to merge xmonad/X11#71 and release X11)

TheMC47 · 2021-03-01T15:38:33Z

I played around with this a bit, and it's definitely an improvement to the UX in my opinion. Awesome work 🎉 I'm not familiar with X.H.Focus or X.A.WorkspaceNames so I didn't get to try them fully (my config is still pretty basic), but I have some suggestions for the documentation of XMonad.Hooks.EwmhDesktops module:

The examples in your personal dotfiles are nice, especially the one with activateHook. I'm only a bit confused on why one would need workspaceListSort
Regarding fullscreen support:
- It might be nice to mention why you wouldn't want fullscreen support. I personally don't use it, because I want picture-in-picture support sometimes. So it's maybe a good idea to mention that and refer to windowedFullscreenFixEventHook
- Since we're making the window float, if the user focuses another window in the same workspace by mistake, they'll have no indication that they're focused on the wrong window. Maybe it makes sense to have a combinator that we can use on windows W.focusUp for example, so it only triggers if no window in the current workspace is in fullscreen mode. It doesn't have to be here, I'm just thinking out loud

It's often difficult to make contrib modules work together. When one depends on a functionality of another, it is often necessary to expose lots of low-level functions and hooks and have the user combine these into a complex configuration that works. This is error-prone, and arguably a bad UX in general. This commit presents a simple solution to that problem inspired by "extensible state": extensible config. It allows contrib modules to store custom configuration values inside XConfig. This lets them create custom hooks, ensure they hook into xmonad core only once, and possibly other use cases I haven't thought of yet. This requires changes to xmonad core: xmonad/xmonad#294 A couple examples of what this gives us: * [X.H.RescreenHook](xmonad#460) can be made safe to apply multiple times, making it composable and usable in other contrib modules like X.H.StatusBar * `withSB` from X.H.StatusBar can also be made safe to apply multiple times, and we can even provide an API [similar to what we had before](https://hackage.haskell.org/package/xmonad-contrib-0.16/docs/XMonad-Hooks-DynamicLog.html#v:statusBar) if we want (probably not, consistency with the new dynamic status bars of xmonad#463 is more important) * The [X.H.EwmhDesktops refactor](xmonad#399) can possibly be made without breaking the `ewmh`/`ewmhFullscreen` API. And we will finally be able to have composable EWMH hooks. Related: xmonad/xmonad#294

Don't assume ewmh/docks are the only xmonad config combinator out there. Related: xmonad#396 Related: xmonad#399

Related: xmonad#396 Related: xmonad#399

Related: xmonad#396 Related: xmonad#399 Related: xmonad#192

Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change to get rid of the annoying border flicker that is inevitable with the current implementation of XMonad.Operations.windows. (Note that Steam also sends ConfigureRequest events, and these cause an additional refresh due to the call to `float` when handling the event in xmonad core. Not sure if worth fixing.) Related: #371 Related: #399

liskin · 2021-05-21T11:25:03Z

I cherry-picked the non-controversial bits into master over the last few days. I intend to reimplement the rest on top of the extensible config stuff (#547) later.

sgf-dma · 2021-05-21T12:35:13Z

In fact, i don't really understand what review you want from me. I have nothing to say about code, because i already forget (again) how all this work. Or you just want, that i try my config on current master?

liskin · 2021-05-21T13:59:16Z

@sgf-dma Once this is in a usable state (right now it's a bit behind current developments), I'd welcome if you tried using it in your config. I remember you had some concerns about this being unwieldy for certain use cases. If you don't remember or don't care, though, I'm fine with that, and I'll just try my best not to break legitimate use cases.

tl;dr: I'll let you know once it's ready.

sgf-dma · 2021-05-21T15:48:27Z

@liskin Ok, thanks. Well, use cases, which i thought essential (when wrote X.H.Focus), are provided in examples in comments. So, it'd be good, if all examples will work.

It's often difficult to make contrib modules work together. When one depends on a functionality of another, it is often necessary to expose lots of low-level functions and hooks and have the user combine these into a complex configuration that works. This is error-prone, and arguably a bad UX in general. This commit presents a simple solution to that problem inspired by "extensible state": extensible config. It allows contrib modules to store custom configuration values inside XConfig. This lets them create custom hooks, ensure they hook into xmonad core only once, and possibly other use cases I haven't thought of yet. This requires changes to xmonad core: xmonad/xmonad#294 A couple examples of what this gives us: * [X.H.RescreenHook](xmonad#460) can be made safe to apply multiple times, making it composable and usable in other contrib modules like X.H.StatusBar * `withSB` from X.H.StatusBar can also be made safe to apply multiple times, and we can even provide an API [similar to what we had before](https://hackage.haskell.org/package/xmonad-contrib-0.16/docs/XMonad-Hooks-DynamicLog.html#v:statusBar) if we want (probably not, consistency with the new dynamic status bars of xmonad#463 is more important) * The [X.H.EwmhDesktops refactor](xmonad#399) can possibly be made without breaking the `ewmh`/`ewmhFullscreen` API. And we will finally be able to have composable EWMH hooks. Related: xmonad/xmonad#294

Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change to get rid of the annoying border flicker that is inevitable with the current implementation of XMonad.Operations.windows. (Note that Steam also sends ConfigureRequest events, and these cause an additional refresh due to the call to `float` when handling the event in xmonad core. Not sure if worth fixing.) Related: xmonad#371 Related: xmonad#399

We have a bunch of open PRs that need features added in X11-1.10. Related: xmonad#274 Related: xmonad#273 Related: xmonad/xmonad-contrib#545 Related: xmonad/xmonad-contrib#546 Related: xmonad/xmonad-contrib#399

We have a bunch of open PRs that need features added in X11-1.10. Related: #274 Related: #273 Related: xmonad/xmonad-contrib#545 Related: xmonad/xmonad-contrib#546 Related: xmonad/xmonad-contrib#399

It's often difficult to make contrib modules work together. When one depends on a functionality of another, it is often necessary to expose lots of low-level functions and hooks and have the user combine these into a complex configuration that works. This is error-prone, and arguably a bad UX in general. This commit presents a simple solution to that problem inspired by "extensible state": extensible config. It allows contrib modules to store custom configuration values inside XConfig. This lets them create custom hooks, ensure they hook into xmonad core only once, and possibly other use cases I haven't thought of yet. This requires changes to xmonad core: xmonad/xmonad#294 A couple examples of what this gives us: * [X.H.RescreenHook](xmonad#460) can be made safe to apply multiple times, making it composable and usable in other contrib modules like X.H.StatusBar * `withSB` from X.H.StatusBar can also be made safe to apply multiple times, and we can even provide an API [similar to what we had before](https://hackage.haskell.org/package/xmonad-contrib-0.16/docs/XMonad-Hooks-DynamicLog.html#v:statusBar) if we want (probably not, consistency with the new dynamic status bars of xmonad#463 is more important) * The [X.H.EwmhDesktops refactor](xmonad#399) can possibly be made without breaking the `ewmh`/`ewmhFullscreen` API. And we will finally be able to have composable EWMH hooks. Related: xmonad/xmonad#294

…tom with it We need to make EwmhDesktops configurable: not just workspaceListTransform, but users also need a way to customize the handling of _NET_ACTIVE_WINDOW, enable/disable fullscreen handling, etc. Instead of having them manually piece together chains of hooks in their XConfigs, let's introduce a EwmhConfig record and a `ewmh'` function that takes care of everything. Related: xmonad#396 Related: xmonad#109

TODO: documentation in X.H.EwmhDesktops TODO: changelog TODO: adapt X.H.Focus Related: xmonad#396 Related: xmonad#110

This makes it easier to use transforms that need some state, e.g. XMonad.Actions.WorkspaceNames could provide this. Related: xmonad#105 Related: xmonad#122 Related: f271d59 ("X.A.WorkspaceNames: Provide workspaceListTransform for EwmhDesktops")

These are useful when one blocks some _NET_ACTIVE_WINDOW requests but still wants to somehow show that a window requested focus. TODO: changelog

…ctrl -s) Turns out that renaming workspaces in the transform is a bad idea in the `ewmhDesktopsEventHook'` as W.view is then unable to find the workspace. This was somewhat usable before we introduced the unified `ewmh'` config combinator as one would only rename in the transform passed to `ewmhDesktopsLogHookCustom`, but with the unified config, we actually need to separate renames from sorting/reordering, otherwise switching workspaces by pagers or wmctrl doesn't work. Related: xmonad#105 Related: xmonad#122 Related: f271d59 ("X.A.WorkspaceNames: Provide workspaceListTransform for EwmhDesktops")

liskin · 2021-06-04T16:55:06Z

(just a rebase so that I can update my daily driver, nothing exciting yet)

We have a bunch of open PRs that need features added in X11-1.10. Related: xmonad#274 Related: xmonad#273 Related: xmonad/xmonad-contrib#545 Related: xmonad/xmonad-contrib#546 Related: xmonad/xmonad-contrib#399

liskin · 2021-10-19T01:23:27Z

#626 implements everything that was here, better, with more (but not all yet!) documentation, so this can finally be closed.

liskin added 9.needs: CHANGES.md needs: documentation labels Nov 5, 2020

liskin added this to the v0.17 milestone Nov 5, 2020

liskin requested review from geekosaur and sgf-dma November 5, 2020 00:47

liskin force-pushed the ewmh-ignoreactivation-managehook branch 4 times, most recently from f861b5b to e28e141 Compare November 16, 2020 11:26

liskin mentioned this pull request Dec 31, 2020

Extend and fix issues with XMonad.Layout.IndependentScreens #438

Merged

3 tasks

liskin mentioned this pull request Jan 15, 2021

Next release (v0.17.0) xmonad/xmonad#264

Closed

16 tasks

liskin force-pushed the ewmh-ignoreactivation-managehook branch from e28e141 to d4235fb Compare January 25, 2021 23:23

liskin closed this Jan 26, 2021

liskin deleted the ewmh-ignoreactivation-managehook branch January 26, 2021 12:04

liskin restored the ewmh-ignoreactivation-managehook branch January 26, 2021 12:08

liskin reopened this Jan 26, 2021

liskin mentioned this pull request Jan 30, 2021

Previously floating fullscreen windows tiles after leaving fullscreen #456

Closed

2 tasks

liskin force-pushed the ewmh-ignoreactivation-managehook branch from d4235fb to 8f6c8d6 Compare January 30, 2021 12:03

liskin mentioned this pull request Feb 4, 2021

added toggle fullscreen feature #395

Closed

4 tasks

liskin force-pushed the ewmh-ignoreactivation-managehook branch from a0555f8 to dfd44cd Compare February 7, 2021 13:48

TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021

X.H.{EwmhDesktops,ManageDocks}: Improve the usage doc a bit

bc5c12e

Don't assume ewmh/docks are the only xmonad config combinator out there. Related: xmonad#396 Related: xmonad#399

TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021

X.{H.EwmhDesktops,L.Fullscreen}: Kill a few warnings

99e8b05

Related: xmonad#396 Related: xmonad#399

TheMC47 pushed a commit to TheMC47/xmonad-contrib that referenced this pull request May 21, 2021

X.H.EwmhDesktops: Clean up "handle"

5f14db5

Related: xmonad#396 Related: xmonad#399 Related: xmonad#192

liskin added 8 commits June 4, 2021 17:19

(wip) X.H.EwmhDesktops: activation via activateHook

3c5f31f

TODO: documentation in X.H.EwmhDesktops TODO: changelog TODO: adapt X.H.Focus Related: xmonad#396 Related: xmonad#110

(wip) X.H.EwmhDesktops: Migrate fullscreen handling to EwmhConfig

b645b0e

(wip) X.H.UrgencyHook: Add askUrgent and doAskUrgent

11c1aed

These are useful when one blocks some _NET_ACTIVE_WINDOW requests but still wants to somehow show that a window requested focus. TODO: changelog

(wip)

1589f87

(wip) TODOs for dropping workspaceNamesRenameWS

b176837

liskin force-pushed the ewmh-ignoreactivation-managehook branch from 8f331d4 to b176837 Compare June 4, 2021 16:47

This was referenced Oct 17, 2021

(wip) Refactor EWMH support #625

Draft

EWMH: Improve interface for custom sorting, filtering, renaming and window activation #626

Merged

liskin closed this Oct 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(wip) Refactor EWMH window activation #399

(wip) Refactor EWMH window activation #399

liskin commented Nov 5, 2020

liskin commented Jan 25, 2021

TheMC47 commented Mar 1, 2021

liskin commented May 21, 2021

sgf-dma commented May 21, 2021

liskin commented May 21, 2021

sgf-dma commented May 21, 2021 •

edited

Loading

liskin commented Jun 4, 2021 •

edited

Loading

liskin commented Oct 19, 2021

(wip) Refactor EWMH window activation #399

(wip) Refactor EWMH window activation #399

Conversation

liskin commented Nov 5, 2020

Description

Checklist

liskin commented Jan 25, 2021

TheMC47 commented Mar 1, 2021

liskin commented May 21, 2021

sgf-dma commented May 21, 2021

liskin commented May 21, 2021

sgf-dma commented May 21, 2021 • edited Loading

liskin commented Jun 4, 2021 • edited Loading

liskin commented Oct 19, 2021

sgf-dma commented May 21, 2021 •

edited

Loading

liskin commented Jun 4, 2021 •

edited

Loading