Fix I2C slave test #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbanth
approved these changes
Oct 6, 2023
|
@ed-xmos, I notice that, at least for this PR, the I2S tests are still skipped. Will you re-enable those (and possibly find further test failures)? |
In the update develop PR I have enabled scanning of all submodules so they are automatically run for that since submodules have been changed. In addition I also manually ran all tests and it was only I2C slave that was failing. So I am happy that these have been and will continue to be regression tested as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xmosjira.atlassian.net/browse/AP-178
Add handshaking so i2c slave test is ready at right time