Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disclaimer to legal.rst #209

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

BrennanGit
Copy link
Contributor

No description provided.

latex has it in the template
Copy link
Contributor

@xluciano xluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrennanGit
Copy link
Contributor Author

although I'm still not sure if this should be in the top-level index instead.

eg:
image

here, the copyright and disclaimer is duplicated in each section.

Bare in mind that it is appended automatically at the end of each of the pdfs so we only need to add it for html.

Maybe even this little block covers our needs completely?
image

Copy link
Collaborator

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomblackie-xmos is the person that decides where we need licence, copyright and disclaimer statements. @BrennanGit, please direct your questions about where they should appear in the HTML documentation to him. This change is suitabel from my point of view.

@tomblackie-xmos
Copy link

@tomblackie-xmos is the person that decides where we need licence, copyright and disclaimer statements. @BrennanGit, please direct your questions about where they should appear in the HTML documentation to him. This change is suitabel from my point of view.

I've had a look at the build artifact and it looks OK - I understand that it is duplicated on the LHS menu, but these are two separate docs so it is not totally illogical. Please go ahead

@xluciano xluciano merged commit 8bc813f into xmos:develop Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants