Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RTOS test failures #222

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix RTOS test failures #222

merged 3 commits into from
Nov 15, 2023

Conversation

ed-xmos
Copy link
Contributor

@ed-xmos ed-xmos commented Nov 14, 2023

@ed-xmos ed-xmos self-assigned this Nov 14, 2023
xluciano
xluciano approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@xluciano xluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are sensible. Can you check if the increased timeout allows re-introducing the steps disabled here?

@ed-xmos
Copy link
Contributor Author

ed-xmos commented Nov 15, 2023

Changes are sensible. Can you check if the increased timeout allows re-introducing the steps disabled here?

Yes - seems to fix it. Just a timeout - reckon flash is slower on the new agent target.

@ed-xmos ed-xmos merged commit 38676bc into xmos:develop Nov 15, 2023
4 checks passed
@ed-xmos ed-xmos deleted the feature/fix_tests branch November 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xluciano xluciano xluciano approved these changes

@mbanth mbanth Awaiting requested review from mbanth

Assignees

@ed-xmos ed-xmos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ed-xmos @xluciano