Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate different performance of avona_ic and py_ic #276

Open
uvvpavel opened this issue May 12, 2022 · 5 comments
Open

Investigate different performance of avona_ic and py_ic #276

uvvpavel opened this issue May 12, 2022 · 5 comments

Comments

@uvvpavel
Copy link
Collaborator

While doing #270 Allan and I saw that avona_ic and py_ic can have the same behaviour when using different configurations. We want to investigate that by adding some test criteria to the existing tests.

@uvvpavel uvvpavel changed the title Evaluate differnt performance of avona_ic and py_ic Investigate different performance of avona_ic and py_ic May 13, 2022
@uvvpavel
Copy link
Collaborator Author

This turns into comparing the filter coefficient between frames to understand where 2 models diverge from each other

@uvvpavel
Copy link
Collaborator Author

I've extended the py_c_frame_compare test to check the filter coefficients in the first ten frames. The wav file from ic example has passed all the tests. Then I gave it a noisy input from the other test and it started failing due to the issue with a 32-bit shift. I have now implemented a workaround in #266 and the test is now passing. @Allan-xmos and I are unsure if it resolves this issue or if there are some other things that we need to find. I need to wait for Jenkins to verify that

@uvvpavel
Copy link
Collaborator Author

The 32-bit shift bug did not resolve this issue. This investigation will be pending for now

@andrewdewhurst
Copy link

  1. This is parked, this issues refers to a specific problem when using different config files, and might be a block floating point “feature”. I suggest we move to AV5, and relook at it once we have the refactored python functions.

keithauxmos pushed a commit to keithauxmos/fwk_voice that referenced this issue Sep 7, 2022
…tion

Remove wifi portions of explorer app
@mbanth
Copy link
Collaborator

mbanth commented Oct 7, 2022

A review by @andrewdewhurst and myself has concluded that we will leave this issue parked for the time being. @andrewdewhurst has requested that the Story Points go to zero during this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants