Skip bootloader on certain devices with rts/dtr connected. (Koenkk#196)

xmow49 · Jul 7, 2020 · eb92214 · eb92214
1 parent 6d40d54
commit eb92214
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 4 deletions.
diff --git a/src/adapter/z-stack/adapter/zStackAdapter.ts b/src/adapter/z-stack/adapter/zStackAdapter.ts
@@ -79,10 +79,16 @@ class ZStackAdapter extends Adapter {
     public async start(): Promise<StartResult> {
         await this.znp.open();
 
-        try {
-            await this.znp.request(Subsystem.SYS, 'ping', {capabilities: 1});
-        } catch (e) {
-            throw new Error(`Failed to connect to the adapter (${e})`);
+        const attempts = 3;
+        for (let i = 0; i < attempts; i++) {
+            try {
+                await this.znp.request(Subsystem.SYS, 'ping', {capabilities: 1});
+                break;
+            } catch (e) {
+                if (attempts - 1 === i) {
+                    throw new Error(`Failed to connect to the adapter (${e})`);
+                }
+            }
         }
 
         // Old firmware did not support version, assume it's Z-Stack 1.2 for now.

diff --git a/src/adapter/z-stack/znp/znp.ts b/src/adapter/z-stack/znp/znp.ts
@@ -202,6 +202,17 @@ class Znp extends events.EventEmitter {
     }
 
     private async skipBootloader(): Promise<void> {
+        // Skip bootloader on some CC2652 devices (e.g. zzh-p)
+        if (this.serialPort) {
+            await this.setSerialPortOptions({dtr: false, rts: false});
+            await Wait(150);
+            await this.setSerialPortOptions({dtr: false, rts: true});
+            await Wait(150);
+            await this.setSerialPortOptions({dtr: false, rts: false});
+            await Wait(150);
+        }
+
+        // Skip bootloader on CC2530/CC2531
         // Send magic byte: https://github.com/Koenkk/zigbee2mqtt/issues/1343 to bootloader
         // and give ZNP 1 second to start.
         const buffer = Buffer.from([0xef]);
@@ -210,6 +221,14 @@ class Znp extends events.EventEmitter {
         await Wait(1000);
     }
 
+    private async setSerialPortOptions(options: {dtr?: boolean; rts?: boolean}): Promise<void> {
+        return new Promise((resolve): void => {
+            this.serialPort.set(options, () => {
+                resolve();
+            });
+        });
+    }
+
     public static async isValidPath(path: string): Promise<boolean> {
         // For TCP paths we cannot get device information, therefore we cannot validate it.
         if (SocketPortUtils.isTcpPath(path)) {

diff --git a/test/adapter/z-stack/znp.test.ts b/test/adapter/z-stack/znp.test.ts
@@ -13,6 +13,7 @@ const mockSerialPortList = jest.fn().mockReturnValue([]);
 const mockSerialPortOpen = jest.fn().mockImplementation((cb) => cb());
 const mockSerialPortConstructor = jest.fn();
 const mockSerialPortOnce = jest.fn();
+const mockSerialPortSet = jest.fn().mockImplementation((opts, cb) => cb());
 const mockSerialPortWrite = jest.fn((buffer, cb) => cb());
 let mockSerialPortIsOpen = false;
 
@@ -30,6 +31,7 @@ jest.mock('serialport', () => {
             once: mockSerialPortOnce,
             open: mockSerialPortOpen,
             pipe: mockSerialPortPipe,
+            set: mockSerialPortSet,
             write: mockSerialPortWrite,
             flush: mockSerialPortFlush,
             isOpen: mockSerialPortIsOpen,
@@ -134,6 +136,7 @@ describe('ZNP', () => {
         expect(mockSerialPortPipe).toHaveBeenCalledTimes(1);
         expect(mockSerialPortOpen).toHaveBeenCalledTimes(1);
         expect(mockUnpiWriterWriteBuffer).toHaveBeenCalledTimes(1);
+        expect(mockSerialPortSet).toHaveBeenCalledTimes(3);
         expect(mockSerialPortOnce).toHaveBeenCalledTimes(2);
     });