Merge pull request #89 from node-xmpp/banana-gorilla

make clone a standalone method

benchmarks/ltx.js

@@ -56,17 +56,17 @@ suite.add('parse', function () {
   parse(XML)
 })
 
-suite.add('serialize', function () {
-  el.toString()
-})
-
 suite.add('createElement (jsx)', function () {
   createElement(
     'message', {to: 'foo@bar', from: 'bar@foo', type: 'chat', id: 'foobar'},
     createElement('body', null, 'Where there is love there is life.')
   )
 })
 
+suite.add('serialize', function () {
+  el.toString()
+})
+
 suite.add('clone', function () {
   el.clone()
 })

lib/Element.js

@@ -10,8 +10,10 @@ var nameEqual = equality.name
 var attrsEqual = equality.attrs
 var childrenEqual = equality.children
 
+var clone = require('./clone')
+
 /**
- * This cheap replica of DOM/Builder puts me to shame :-)
+ * Element
  *
  * Attributes are in the element.attrs object. Children is a list of
  * either other Elements or Strings for text content.
@@ -283,18 +285,8 @@ Element.prototype.remove = function (el, xmlns) {
   return this
 }
 
-/**
- * To use in case you want the same XML data for separate uses.
- * Please refrain from this practise unless you know what you are
- * doing. Building XML with ltx is easy!
- */
 Element.prototype.clone = function () {
-  var clone = new this.constructor(this.name, this.attrs)
-  for (var i = 0; i < this.children.length; i++) {
-    var child = this.children[i]
-    clone.cnode(child.clone ? child.clone() : child)
-  }
-  return clone
+  return clone(this)
 }
 
 Element.prototype.text = function (val) {

lib/clone.js

@@ -0,0 +1,10 @@
+'use strict'
+
+module.exports = function clone (el) {
+  var clone = new el.constructor(el.name, el.attrs)
+  for (var i = 0; i < el.children.length; i++) {
+    var child = el.children[i]
+    clone.cnode(child.clone ? child.clone() : child)
+  }
+  return clone
+}