Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug CLI methods #1254

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add debug CLI methods #1254

merged 1 commit into from
Nov 12, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Nov 11, 2024 •
edited
Loading

tl;dr

  • Adds a debug section to the CLI
  • Adds the first debug method to read raw payloads from the network
  • Changes the way we specify envs in the CLI

@neekolas Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on Graphite Graphite

insipx
insipx reviewed Nov 11, 2024
View reviewed changes
examples/cli/Cargo.toml Outdated Show resolved Hide resolved
@neekolas neekolas force-pushed the 11-10-add_debug_cli_methods branch 4 times, most recently from 34e14b2 to f725ce6 Compare November 12, 2024 05:43
neekolas
neekolas commented Nov 12, 2024
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
@neekolas neekolas marked this pull request as ready for review November 12, 2024 15:18
@neekolas neekolas requested a review from a team as a code owner November 12, 2024 15:18
@insipx insipx merged commit f37234a into main Nov 12, 2024
17 checks passed
@insipx insipx deleted the 11-10-add_debug_cli_methods branch November 12, 2024 18:14
@mkysel
Copy link
Contributor

mkysel commented Nov 12, 2024

This is cool! I will need the other message types too. Hoping to have it done as a follow-up by tomorrow

@mkysel mkysel mentioned this pull request Nov 13, 2024
Merged
mkysel added a commit that referenced this pull request Nov 14, 2024
@mkysel
Extend the debug capabities of the CLI (#1260)
87c9c3f 
Add the other three message types.

Change the parsing of the options to match other commands and allow the user to omit `--group-id` if there is only one named argument required.

Builds on top of #1254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neekolas @mkysel @insipx