feat(groups): add a worker to delete expired messages #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchenani
commented
Jan 14, 2025
mchenani
commented
Jan 14, 2025
mchenani
commented
Jan 16, 2025
xmtp_mls/migrations/2025-01-16-143131_add_message_expiration_to_groups/up.sql
Outdated
Show resolved
Hide resolved
insipx
reviewed
Jan 17, 2025
insipx
reviewed
Jan 17, 2025
mchenani
commented
Jan 17, 2025
mchenani
commented
Jan 24, 2025
mchenani
commented
Jan 24, 2025
codabrink
reviewed
Jan 24, 2025
codabrink
reviewed
Jan 24, 2025
insipx
previously approved these changes
Jan 27, 2025
insipx
previously approved these changes
Jan 27, 2025
insipx
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a worker that runs every two seconds to clean up expired messages based on group disappearing settings. It also updates the message expiration policy to align with the new disappearing message policy.
Key Changes
• Replaced message_expiration_ms_policy with message_disappearing_policy.
• Added new structures for disappearing settings and updated group options to use them.
• Added methods to update, remove, and fetch disappearing settings for conversations.
• Updated tests to reflect the new policy and added a test for disappearing messages.
closes #1449