Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename contracts appropriately #1

Merged
merged 1 commit into from
Mar 19, 2025
Merged

refactor: Rename contracts appropriately #1

merged 1 commit into from
Mar 19, 2025

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 17, 2025
@deluca-mike deluca-mike requested review from neekolas and fbac March 17, 2025 16:48
@deluca-mike deluca-mike self-assigned this Mar 17, 2025
fbac
fbac previously approved these changes Mar 18, 2025
View reviewed changes
@deluca-mike deluca-mike force-pushed the refactor/rename-contracts branch from a7cbd56 to 784be6f Compare March 18, 2025 17:06
@github-actions GitHub Actions
Copy link

Changes to gas cost

Generated at commit: e5e742078847928d500f65023b395d69846c0815, compared to commit: 6f2de5e914ac3d8b04bb3bf33d4baf868df8e723

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC1967Proxy 228,395 (0) fallback 695 (0) 0.00% 509,463 (+24,669) +5.09% 36,792 (0) 0.00% 169,212,871 (0) 0.00% 2,529 (0)

@github-actions GitHub Actions
Copy link

LCOV of commit 784be6f during Solidity #14

Summary coverage rate:
  lines......: 98.0% (245 of 250 lines)
  functions..: 96.9% (63 of 65 functions)
  branches...: 92.3% (48 of 52 branches)

Files changed coverage rate:
                                   |Lines       |Functions  |Branches    
  Filename                         |Rate     Num|Rate    Num|Rate     Num
  =======================================================================
  src/GroupMessageBroadcaster.sol  |25.6%     39|70.0%    10|    -      0
  src/IdentityUpdateBroadcaster.sol|25.6%     39|70.0%    10|    -      0
  src/NodeRegistry.sol             |27.5%    131|91.2%    34|    -      0
  src/RateRegistry.sol             |25.0%     36|77.8%     9|    -      0

@deluca-mike deluca-mike merged commit 7231951 into main Mar 19, 2025
9 checks passed
@deluca-mike deluca-mike deleted the refactor/rename-contracts branch March 25, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbac fbac fbac approved these changes

@neekolas neekolas Awaiting requested review from neekolas

Assignees

@deluca-mike deluca-mike

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Decentralization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deluca-mike @fbac