-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helpers and actions #2
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
19e3cd2
to
607a54a
Compare
Are we losing soldeer with this pr? |
2a33db9
to
54411b1
Compare
Sadly yes, for several reasons (listed in most significant to least)
I always wanted to give soldeer a try, having come from using git submodules for years, but after playing around with it for a week, it doesn't seem to offer any real benefits. I have found that relative paths in imports result in the most portable and "fix free" codebase. I was hoping soldeer would be the best of both worlds. But if we can address some of the above, would be happy to use soldeer. It is possible I am using it wrong. |
54411b1
to
e9d6656
Compare
e9d6656
to
a34a18c
Compare
LCOV of commit
|
I'm not sure I follow you. It doesn't do that and you can reference dependencies as
Also don't follow, this seems to be a local misconfiguration.
Also local/subjective. |
No description provided.