Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Sanctuary dependencies to latest versions #14

Merged
merged 10 commits into from
Nov 11, 2019
Merged

update Sanctuary dependencies to latest versions #14

merged 10 commits into from
Nov 11, 2019

Conversation

EricLanduyt
Copy link
Contributor

I couldn't use hm-def with latest Sanctuary, so I updated all the libs to their latest version, with the help of @davidchambers :

  • sanctuary ^2.0.1
  • sanctuary-def ^0.20.1
  • sanctuary-type-classes ^11.0.0

I also had to fix tests, and replaced assertType() by assertTypes():

  • now use Setoid's equals() to compare Array of Type without looking at their internals.
  • removed S.zip(), because it only compares based on the length of the shortest array (ex: test is considered as valid if first array is empty and second is not).

@EricLanduyt
sanctuary ^1.0.0, sanctuary-def ^0.19.0, sanctuary-show ^1.0.0
d6acc28
@EricLanduyt
sanctuary-type-classes ^11.0.0
2665182
@EricLanduyt
sanctuary ^1.1.0
4d5a14a
@EricLanduyt
sanctuary ^2.0.0, sanctuary-def ^0.20.0
8dbe273
@EricLanduyt
Wrapper UnaryType has much cleaner predicate (suggested by David Cham…
40ac592 
…bers)
@EricLanduyt
fixed wrong asserts because change in predicate's first argument (Dav…
bd26594 
…id Chambers, "We need t._test ([]) rather than t._test because _test now takes an environment as its first argument. We were only partially applying the predicate, which meant we were always getting back a function which was then coerced to true.")
@EricLanduyt
output diff of actual/expected in case of assert failure
1e4449e
@EricLanduyt
fixed possible wrong asserts because S.zip() stops on shorter array
086d980
@EricLanduyt
make linter happy
b6f701e
@EricLanduyt
sanctuary ^2.0.1, sanctuary-def ^0.20.1
3a090e4
davidchambers
davidchambers approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@davidchambers davidchambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fantastic!

@nkrkv
Copy link
Member

nkrkv commented Nov 11, 2019

Thanks, folks, this is great!

@nkrkv nkrkv merged commit 9d4ea17 into xodio:master Nov 11, 2019
@EricLanduyt
Copy link
Contributor Author

Thank you very much for the merge @nkrkv !

What about also merging @Gipphe 's MR ( #13 ), and then doing a small release with these ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidchambers davidchambers davidchambers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricLanduyt @nkrkv @davidchambers