Explicitly use fresh node-gyp #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
approved these changes
Nov 22, 2018
brusherru
approved these changes
Nov 22, 2018
evgenykochetkov
force-pushed
the
chore-explicitly-use-fresh-node-gyp
branch
from
674e999
to
1dcd6b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version we used before is 3.6.2:
xod/yarn.lock
Lines 10296 to 10297 in 28b13bb
which is
node-sass's dependency: https://github.com/xodio/xod/blob/master/yarn.lock#L10444It is quite old and among others has this issue that causes lots of pain on fresh macOS versions.