Node reducer was refactored #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nailxx Wait a moment. Weird conflicts presence again :( |
…itions and sizes for all elements on patch and pass it into components
…y that binds methods and data for component (in constructor)
…asks better (though not as elegant looks)
…there is unable to resolve path to module somehow)
…e width, correct eslint and etc
scalamorphing
force-pushed
the
refactor-nodes-reducer
branch
from
ddb4173
to
3ce6919
Compare
|
@nailxx Done. |
|
It should be fixed by @brusherru I think |
| @@ -22,7 +22,7 @@ module.exports = { | |||
| ], | |||
|
|
|||
| 'settings': { | |||
| 'import/resolver': ['node', 'webpack'], | |||
| 'import/resolver': {'node': {"extensions": [".js", ".jsx"]}, 'webpack': {}}, | |||
There was a problem hiding this comment.
Hmm.., does it work that way? What’s the difference between node & webpack in our context?
There was a problem hiding this comment.
I am not into these details and am not alone.
Read following discussion: import-js/eslint-plugin-import#139
There was a problem hiding this comment.
Thanks. So can we remove webpack key from resolver settings completely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.