Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make xmp removal optional #9

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Conversation

Aleclindner
Copy link
Contributor

See this comment and the new readme update: #6 (review)

Makes XMP removal optional for our users who need to leave XMP intact in their files.

@github-actions github-actions bot added core documentation Improvements or additions to documentation labels Jun 14, 2021
@Aleclindner Aleclindner changed the title Make xmp removal optional feat: Make xmp removal optional Jun 14, 2021
Copy link

@xOIBrandon xOIBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

All the existing tests still pass but I notice we didn't add a new case for the new feature.
Is it not worth the trouble to add one? Do you feel good about merging it as is?

@Aleclindner
Copy link
Contributor Author

@xOIBrandon this should be covered by existing PNG tests

@xOIBrandon
Copy link

@Aleclindner I would merge it but I know its been a long time coming and thought maybe you'd like to hit the big green button?

@Aleclindner Aleclindner merged commit 61f0dd1 into develop Jun 22, 2021
@Aleclindner Aleclindner deleted the make-xmp-removal-optional branch June 22, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants