Support plugin config in the extends option
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Nov 12, 2016
| @@ -145,6 +145,11 @@ function buildConfig(opts) { | |||
| return name; | |||
| } | |||
|
|
|||
| // don't do anything if it's a config from a plugin | |||
| if (name.indexOf('plugin:') === 0) { | |||
| const config = manager.buildConfig({extends: extendsOption}); | ||
| t.is(config.baseConfig.extends[config.baseConfig.extends.length - 3], 'plugin:foo/bar'); | ||
| t.is(config.baseConfig.extends[config.baseConfig.extends.length - 2], 'cwd/eslint-config-foo-bar'); | ||
| t.is(config.baseConfig.extends[config.baseConfig.extends.length - 1], 'cwd/eslint-config-foo-bar-two'); |
There was a problem hiding this comment.
Too much boilerplate. Put config.baseConfig.extends in a variable and use it.
| const extendsConfig = config.baseConfig.extends; | ||
| t.is(extendsConfig[extendsConfig.length - 3], 'plugin:foo/bar'); | ||
| t.is(extendsConfig[extendsConfig.length - 2], 'cwd/eslint-config-foo-bar'); | ||
| t.is(extendsConfig[extendsConfig.length - 1], 'cwd/eslint-config-foo-bar-two'); |
There was a problem hiding this comment.
Actually, would be even nicer to just Array#slice() off the items we want an do an t.deepEqual.
sindresorhus
changed the title
extends option
sindresorhus
approved these changes
Nov 13, 2016
|
Thanks :) |
sindresorhus
pushed a commit
that referenced
this pull request
Nov 13, 2016
|
No problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue
XO allows to specify sharable configs to override any of the default rules link. However, in ESLint it is allowed to use configs shared by plugins (prefixed with
eslint-plugin-, next to shared configs (prefixed witheslint-config-and absolute/relative paths. These plugin configs are prefixed withplugin:, see here.Contribution
This PR allows to specify such plugin configs in the XO configuration, by checking whether the name starts with
plugin:and only prependingeslint-config-if that is not the case.