Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor user configured rules #672

Closed
wants to merge 2 commits into from
Closed

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Jun 21, 2022

  • fix failing tests
  • add a test

atm, users cannot disable the rules, as the defaults was always applied.
fixes #670 fixes #613

atm, users cannot disable the rules, as the defaults was always applied.
fixes xojs#670
@aladdin-add
Copy link
Contributor Author

the build is failing as ?. and ?? was not supported in node v12, will try to make a change later.

@fregante
Copy link
Member

fregante commented Jul 18, 2024

Is this still mergeable or necessary? Node 12 is long gone so it shouldn't be blocked anymore.

@sindresorhus
Copy link
Member

It may be moot with flat config and I also don't want to take the risk of breakage, since XO is going to change a lot anyway with flat config.

@fregante
Copy link
Member

I also don't want to take the risk of breakage

Understandable, but due to both #613 and #598, I'm seeing errors related to Node in a non-Node project, and they require inline exclusions.

One example is:

✖    7:9   The navigator is still an experimental feature The configured version range is >= 20.                                                                          n/no-unsupported-features/node-builtins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants