Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharpYaml dependencies #54

Closed
sergey-tihon opened this issue Apr 27, 2018 · 5 comments · Fixed by #92
Closed

SharpYaml dependencies #54

sergey-tihon opened this issue Apr 27, 2018 · 5 comments · Fixed by #92

Comments

@sergey-tihon
Copy link

Latest version v1.6.3 has dependency on System.Reflection.TypeExtentions v.4.1.0.0
win10_-_fall_creators

nuspec say that you depend on system.reflection.typeextensions.4.3.0.nupkg or later.
There is a dll inside this NuGet package in lib\netstandard1.5\ that has version 4.1.1.0
win10_-_fall_creators

So, there is no way to use SharpYaml wihtout binding redirects =(
It is possible to fix it?
@sergey-tihon sergey-tihon mentioned this issue Apr 27, 2018
Merged
5 tasks
@xoofx
Copy link
Owner

xoofx commented Apr 27, 2018

Are you trying to target .NET Standard 2.0?

@xoofx
Copy link
Owner

xoofx commented Apr 27, 2018

Recently someone added support for netstandard1.3 and added a dependency to TypeExtensions.4.3.0 (here) Would a 4.1.1 work better in that case? I'm confused because you make a reference to lib\netstandard1.5\ (while the F# issue talks for the netstandard2.0)

@sergey-tihon
Copy link
Author

Sorry, I did provide bad interpretation of the issue...
Yes, I do compile FSharp.Configuration for netstandard2.0 and then it fails at runtime because cannot load System.Reflection.TypeExtentions 4.1.0.0 referenced by SharpYaml
win10_-_fall_creators

@xoofx
Copy link
Owner

xoofx commented Jun 7, 2018

For netstandard2.0, many issues are somehow resolved by providing a dedicated netstandard2.0 version, so PR welcome if you want.

@sergey-tihon
Copy link
Author

@xoofx Thank you recommendations and support here.
This not a issue for me anymore, so I close the issue.

kzu added a commit to kzu/SharpYaml that referenced this issue Sep 15, 2021
@kzu
Remove dependency on System.Reflection.TypeExtensions from netstandar…
2114a41 
…d2.0

This dependency isn't necessary for NS2, as noted by @xoofx in xoofx#54.

Fixes xoofx#54 and also makes it usable under MSBuild when targeting NS2 :)
@kzu kzu mentioned this issue Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on System.Reflection.TypeExtensions from netstandad2.0 kzu/SharpYaml
2 participants
@xoofx @sergey-tihon