Use .NET built-in Tar and Zip handling #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes executable bit handling from macOS. Also simplifies zip and tar creation by not relying on an external library.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #63,
dotnet-packaginghas an issue where executable bits are not set properly.Instead of using
dotnet-packagingfor tar and zip creation, just use built-in .NET functions, which handles this case automatically for you. This removes the need fordotnet-packagingin these two instances.I did not know what to do if the output file already existed, so I made that a failure case since there is a
--forceCLI option.I also added a test case for this.
Fixes #63