Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to handle protocol-less media? #135

Closed
sethreidnz opened this issue Aug 15, 2017 · 4 comments
Closed

Possible to handle protocol-less media? #135

sethreidnz opened this issue Aug 15, 2017 · 4 comments

Comments

@sethreidnz
Copy link

For example when using Contentful the media is returned as such:

//videos.contentful.com/4kxhtjjektmk/5jNKj0uP68Kw0uW0MIasOw/5628599e3424c29ba3a2ea2188d3d686/B80233.mp4

Would you accept a PR to handle this case if I can get it together? Or any thoughts on why this would be a bad idea?

@xoofx
Copy link
Owner

xoofx commented Aug 15, 2017

Not sure what do you mean by handle? Typically if you use this with a image url, it works correctly as seen on babelmark

@sethreidnz
Copy link
Author

sethreidnz commented Aug 15, 2017 via email

@xoofx
Copy link
Owner

xoofx commented Aug 15, 2017

Yep, sounds reasonable, PR welcome.

@sethreidnz
Copy link
Author

I'll try my best this weekend when I have time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants