Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add xopconsole - human & machine readable logger #100

Merged
merged 57 commits into from
Dec 28, 2023
Merged

[feat] Add xopconsole - human & machine readable logger #100

merged 57 commits into from
Dec 28, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Dec 28, 2023

Add the xopconsole base logger. xopconsole support replay and tries to be human-readable.

Also: add a test for metadata duration attributes, fix OTEL base logger handling of metadata duration.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 417 lines in your changes are missing coverage. Please review.

Comparison is base (0a9ba53) 76.45% compared to head (b2d3fb4) 76.97%.

Files Patch % Lines
xopconsole/replay.go 62.41% 234 Missing and 93 partials ⚠️
xopconsole/attributes.go 93.30% 25 Missing and 11 partials ⚠️
xopconsole/console.go 88.14% 25 Missing and 7 partials ⚠️
xopproto/extra.go 0.00% 20 Missing ⚠️
internal/util/version/version_split.go 0.00% 1 Missing ⚠️
xopat/attributes.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   76.45%   76.97%   +0.52%     
==========================================
  Files          65       68       +3     
  Lines        9426    11194    +1768     
==========================================
+ Hits         7207     8617    +1410     
- Misses       1819     2060     +241     
- Partials      400      517     +117     
Flag Coverage Δ
go_tests 76.97% <76.66%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muir muir merged commit 88284b1 into main Dec 28, 2023
13 checks passed
@muir muir deleted the console branch December 28, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants