Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs fixed and embedded enum now tested #44

Merged
merged 1 commit into from
Aug 30, 2022
Merged

bugs fixed and embedded enum now tested #44

merged 1 commit into from
Aug 30, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Aug 30, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 47.31% // Head: 50.44% // Increases project coverage by +3.13% 🎉

Coverage data is based on head (bb32cd1) compared to base (6e02b9b).
Patch coverage: 47.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   47.31%   50.44%   +3.13%     
==========================================
  Files          37       37              
  Lines        3462     3475      +13     
==========================================
+ Hits         1638     1753     +115     
+ Misses       1756     1654     -102     
  Partials       68       68              
Flag Coverage Δ
go_tests 50.44% <47.61%> (+3.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
span.go 62.71% <ø> (+8.47%) ⬆️
xoptest/testlogger.go 59.23% <46.34%> (+7.36%) ⬆️
xopjson/jsonlogger.go 59.41% <100.00%> (+0.97%) ⬆️
basegroup.go 44.23% <0.00%> (+1.84%) ⬆️
sub.go 23.27% <0.00%> (+3.14%) ⬆️
xopconst/enum.go 30.76% <0.00%> (+5.12%) ⬆️
xopjson/attributes.go 57.69% <0.00%> (+9.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 724a22a into main Aug 30, 2022
@muir muir deleted the thirtyfive branch August 30, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants