Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage for Sub's methods to 50 percent. #47

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Conversation

miccagiann
Copy link
Collaborator

Adding tests for Sub type.

Something to touch later: I cannot understand the func (settings LogSettings) Copy() LogSettings. It seems to me that it returns the same LogSettings instance instead of creating a new one.

@muir
Copy link
Collaborator

muir commented Sep 4, 2022

LogSettings has no pointers, maps, or slices in it and thus a copy is a copy and not linked.

@muir
Copy link
Collaborator

muir commented Sep 4, 2022

LogSettings has no pointers, maps, or slices in it and thus a copy is a copy and not linked.

Hmm, that's not right with respect to prefill.

@muir
Copy link
Collaborator

muir commented Sep 4, 2022

LogSettings has no pointers, maps, or slices in it and thus a copy is a copy and not linked.

Hmm, that's not right with respect to prefill.

And prefill is copied.

Copy link
Collaborator

@muir muir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miccagiann miccagiann merged commit f05f329 into main Sep 4, 2022
@miccagiann miccagiann deleted the sub-tests branch September 4, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants