Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xop proto uploader #88

Merged
merged 13 commits into from
Nov 23, 2022
Merged

Add xop proto uploader #88

merged 13 commits into from
Nov 23, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Nov 20, 2022

This is a first version of a protobuf uploader using the xop native protocol
It's not yet high performance but should be okay for now.
Test coverage is so-so.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Base: 87.13% // Head: 87.19% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (3f6e287) compared to base (e5a638c).
Patch coverage: 82.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   87.13%   87.19%   +0.05%     
==========================================
  Files          45       48       +3     
  Lines        5124     5468     +344     
==========================================
+ Hits         4465     4768     +303     
- Misses        564      590      +26     
- Partials       95      110      +15     
Flag Coverage Δ
go_tests 87.19% <82.61%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xopjson/models.go 68.42% <ø> (ø)
xoptest/xoptestutil/enums.go 80.00% <ø> (ø)
xoptrace/trace.go 83.80% <ø> (ø)
xoputil/skip.go 7.14% <0.00%> (ø)
xopat/attributes.go 51.16% <53.84%> (+4.86%) ⬆️
xopmiddle/utils.go 58.97% <66.66%> (ø)
xoptrace/hexbytes.go 74.14% <66.66%> (ø)
xopup/upload.go 75.29% <75.29%> (ø)
xopotel/otel.go 85.50% <80.00%> (ø)
span.go 84.74% <83.33%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir requested a review from miccagiann November 21, 2022 06:51
Copy link
Collaborator

@miccagiann miccagiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@muir muir merged commit 6147449 into main Nov 23, 2022
@muir muir deleted the seventysix branch November 23, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants