Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xopotel simplify #91

Merged
merged 37 commits into from
Apr 22, 2023
Merged

Xopotel simplify #91

merged 37 commits into from
Apr 22, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Apr 2, 2023

BREAKING CHANGE - xopotel

This change renames the xopotel public functions and adds additional ones and documentation.

Additional minor breaking changes are:

  • xopbase.AttributeParts has been renamed xopbase.Builder
  • xoptestutil.EventCount has moved to recorderutil
  • xoptestutil.DumpEvents has been moved to recorderutil

Bugfixes

  • xopcon.Logger.SetPrefix now works
  • xoptest now outputs text via xopcon

Non-breaking changes outside of xopotel include:

  • xoprecorder.Logger now has a SpanIndex
  • xoprecorder.Span now has Links
  • various models now support .Copy
  • xoprecorder replay now has ReplayLineData()

@muir muir changed the base branch from main to redo April 2, 2023 07:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 69.15% and project coverage change: -1.22 ⚠️

Comparison is base (8c7d904) 77.68% compared to head (7254470) 76.47%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   77.68%   76.47%   -1.22%     
==========================================
  Files          65       63       -2     
  Lines        9489     9416      -73     
==========================================
- Hits         7372     7201     -171     
- Misses       1743     1816      +73     
- Partials      374      399      +25     
Flag Coverage Δ
go_tests 76.47% <69.15%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xopbase/base.go 50.00% <ø> (ø)
xoprecorder/recorderutil/counts.go 100.00% <ø> (ø)
xoprecorder/recorderutil/dump.go 92.00% <ø> (ø)
xopbase/model.go 44.55% <41.66%> (-0.39%) ⬇️
xoptest/testlogger.go 85.36% <57.14%> (-14.64%) ⬇️
xopotel/buffered.go 58.31% <58.31%> (ø)
internal/util/generic/map.go 66.66% <66.66%> (ø)
xopotel/export.go 60.51% <71.50%> (+9.11%) ⬆️
xoprecorder/replay.go 78.62% <76.19%> (-2.27%) ⬇️
xopotel/otel.go 83.64% <83.55%> (+0.18%) ⬆️
... and 7 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir marked this pull request as ready for review April 3, 2023 04:19
Base automatically changed from redo to main April 7, 2023 18:48
@muir muir force-pushed the xopotel-simplify branch 2 times, most recently from ec11639 to d441427 Compare April 8, 2023 03:09
@muir muir merged commit f67e104 into main Apr 22, 2023
@muir muir deleted the xopotel-simplify branch April 22, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants