Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change - top level API - log levels #96

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Breaking change - top level API - log levels #96

merged 1 commit into from
Dec 30, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Apr 23, 2023

The expectation is that the new "Log" level will be the default level people use.

Adding "Log()" as a level, created a conflict with the "Log()" that is used to create loggers, so the top-level logger changed from "Log" to "Logger".

That creates a name conflict that is not resolved with xopbase.Logger, the lower level logger ("exporter" in OTEL vocab).

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (7570833) 76.93% compared to head (bdedc7c) 76.95%.

Files Patch % Lines
logger.go 93.62% 11 Missing and 2 partials ⚠️
sub.go 86.95% 2 Missing and 1 partial ⚠️
span.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   76.93%   76.95%   +0.01%     
==========================================
  Files          68       68              
  Lines       11195    11204       +9     
==========================================
+ Hits         8613     8622       +9     
  Misses       2065     2065              
  Partials      517      517              
Flag Coverage Δ
go_tests 76.95% <93.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muir muir merged commit a5ad1de into main Dec 30, 2023
13 checks passed
@muir muir deleted the levels branch December 30, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant