Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make function create_embedding could receive extra args #1224

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

amumu96
Copy link
Contributor

@amumu96 amumu96 commented Apr 1, 2024

No description provided.

@XprobeBot XprobeBot added this to the v0.10.1 milestone Apr 1, 2024
@qinxuye qinxuye changed the title create_embedding透传参数 ENH: create_embedding透传参数 Apr 1, 2024
@XprobeBot XprobeBot added the enhancement New feature or request label Apr 1, 2024
@amumu96 amumu96 changed the title ENH: create_embedding透传参数 ENH: make fucntion create_embedding could receive extra args Apr 1, 2024
@qinxuye qinxuye changed the title ENH: make fucntion create_embedding could receive extra args ENH: make function create_embedding could receive extra args Apr 2, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pre-commit

rerank receive kwargs

rerank、

fix

check valid params

modify receive params method
@ChengjieLi28 ChengjieLi28 merged commit 6ef2815 into xorbitsai:main Apr 3, 2024
10 of 12 checks passed
@amumu96 amumu96 deleted the normalize_fix branch April 9, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants