ENH: support int and str compare for model size #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
changed the title
The origin version only support underscore as float point, like 1_8. Now the more intuitive form like 1.8 is supported too.
ChengjieLi28
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if LLM Spec's
model_size_in_billionsis int, but client send the string, or vice versa, the launch model command will fail.For example,
model_size_in_billionsin LLM Spec is 32, but the parameter in launch model command is "32", it fails.This PR makes this judgment smarter, so 32 will equal to "32", or "1.8" will equal to "1_8".