Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG:Fix mertics is empty when call /v1/chat/completions #1406

Merged
merged 2 commits into from
May 1, 2024

Conversation

amumu96
Copy link
Contributor

@amumu96 amumu96 commented Apr 29, 2024

Fix #1374

@XprobeBot XprobeBot added this to the v0.11.0 milestone Apr 29, 2024
@amumu96 amumu96 changed the title BUG:Fix BUG:Fix mertics is empty when call "/v1/chat/completions" Apr 29, 2024
@amumu96 amumu96 changed the title BUG:Fix mertics is empty when call "/v1/chat/completions" BUG:Fix mertics is empty when call /v1/chat/completions Apr 29, 2024
@codingl2k1
Copy link
Contributor

Does the PR fix this issue? #1374 Could you add some tests?

@amumu96
Copy link
Contributor Author

amumu96 commented Apr 29, 2024

Does the PR fix this issue? #1374 Could you add some tests?

Yes

Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codingl2k1 codingl2k1 merged commit 3b03520 into xorbitsai:main May 1, 2024
12 checks passed
@amumu96 amumu96 deleted the fix_metrics branch June 3, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker metrics is empty
3 participants