Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix start worker failed due to None device name #1539

Merged
merged 3 commits into from
May 24, 2024
Merged

BUG: Fix start worker failed due to None device name #1539

merged 3 commits into from
May 24, 2024

Conversation

codingl2k1
Copy link
Contributor

Fixes: #1517

@XprobeBot XprobeBot added the bug Something isn't working label May 23, 2024
@XprobeBot XprobeBot added this to the v0.11.2 milestone May 23, 2024
qinxuye
qinxuye approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it, can work

@qinxuye qinxuye marked this pull request as ready for review May 24, 2024 02:32
@qinxuye
Copy link
Contributor

qinxuye commented May 24, 2024

I modified because previous change cannot pass CI, now if device env name is None, just use CUDA_VISIBLE_DEVICES which is identical to previous behavior.

@qinxuye qinxuye merged commit 7c6465c into xorbitsai:main May 24, 2024
11 of 12 checks passed
@codingl2k1
Copy link
Contributor Author

I modified because previous change cannot pass CI, now if device env name is None, just use CUDA_VISIBLE_DEVICES which is identical to previous behavior.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.11.2
3 participants
@codingl2k1 @qinxuye @XprobeBot