Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: add gemma-2-it #1774

Merged
merged 2 commits into from
Jul 5, 2024
Merged

FEAT: add gemma-2-it #1774

merged 2 commits into from
Jul 5, 2024

Conversation

qinxuye
Copy link
Contributor

@qinxuye qinxuye commented Jul 3, 2024 •
edited by ChengjieLi28
Loading

Fixes #1750

This PR added gemma-2-it. Some notions:

  1. When I ran gguf formats with llama-cpp-python==0.2.81, it crashed, and I can see the gemma-2 format is introduced lately in llama.cpp itself, so I removed gguf formats for now.
  2. vllm implemented gemma-2 but it's not released, thus vllm is absent as well.
  3. I added MLX format which worked well on my laptop. (Hence this PR replies on FEAT: support MLX engine #1765 )

@XprobeBot XprobeBot added this to the v0.12.4 milestone Jul 3, 2024
@qinxuye qinxuye marked this pull request as ready for review July 5, 2024 08:26
@qinxuye qinxuye merged commit 007408c into xorbitsai:main Jul 5, 2024
12 of 13 checks passed
@qinxuye qinxuye deleted the feat/gemma-2 branch July 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amumu96 amumu96 amumu96 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Gemma2 Supported ?
3 participants
@qinxuye @amumu96 @XprobeBot