Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make MiniCPM v2.6 support video #2068

Merged
merged 13 commits into from
Aug 16, 2024

Conversation

Minamiyama
Copy link
Contributor

8.12.1.mp4

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 12, 2024
@XprobeBot XprobeBot added this to the v0.14.0 milestone Aug 12, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Aug 15, 2024

GPU CI failed: https://github.com/xorbitsai/inference/actions/runs/10382926517/job/28746934032?pr=2068

Looks like new package introduced? Could you move the import into the function, refer to

try:
from transformers import BitsAndBytesConfig, T5EncoderModel
except ImportError:
error_message = "Failed to import module 'transformers'"
installation_guide = [
"Please make sure 'transformers' is installed. ",
"You can install it by `pip install transformers`\n",
]

@Minamiyama
Copy link
Contributor Author

GPU CI failed: https://github.com/xorbitsai/inference/actions/runs/10382926517/job/28746934032?pr=2068

Looks like new package introduced? Could you move the import into the function, refer to

try:
from transformers import BitsAndBytesConfig, T5EncoderModel
except ImportError:
error_message = "Failed to import module 'transformers'"
installation_guide = [
"Please make sure 'transformers' is installed. ",
"You can install it by `pip install transformers`\n",
]

done

@qinxuye
Copy link
Contributor

qinxuye commented Aug 15, 2024

@Minamiyama
Copy link
Contributor Author

https://github.com/xorbitsai/inference/actions/runs/10399318614/job/28798033361?pr=2068

Looks like there is installation issue for Mac.

all done

xinference/core/chat_interface.py Outdated Show resolved Hide resolved
xinference/core/chat_interface.py Outdated Show resolved Hide resolved
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
Copy link
Contributor

qinxuye commented Aug 16, 2024

@qinxuye qinxuye merged commit e04eb43 into xorbitsai:main Aug 16, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants