New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix asyncio.Queue error in benchmark #2113

Merged

qinxuye merged 1 commit into xorbitsai:main from Dawnfz-Lenfeng:fix_queue

Aug 19, 2024

Contributor

Dawnfz-Lenfeng commented Aug 19, 2024

fix benchmark异步并行测试报错 #2111
Previously, asyncio.Queue was created in the __init__ method rather than in the run() function. In lower versions of Python (e.g., 3.9), this could cause the queue to be attached to an incorrect event loop.
To address this issue, the creation of the queue has been moved to the warm_up method.
Additionally, a minor error in a log message has been corrected.


          fix async.Queue

2090f06

XprobeBot added the bug label

XprobeBot added this to the v0.14 milestone

Dawnfz-Lenfeng mentioned this pull request

benchmark异步并行测试报错 #2111

Closed

3 tasks

qinxuye approved these changes

View reviewed changes

Contributor

qinxuye left a comment

LGTM

qinxuye merged commit 05b6180 into xorbitsai:main

13 checks passed

Dawnfz-Lenfeng deleted the fix_queue branch

September 11, 2024 07:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug