Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix concurrent ops in worker initialization #2125

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

frostyplanet
Copy link
Contributor

During worker startup and receive launch_builtin_model concurrently, there were error log:

2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR Connected to supervisor as a fresh worker
2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR  Enter launch_builtin_model, args: ... 
2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR report_event error: 'WorkerActor' object has no attribute '_event_collector_ref

在 worker重启的同时 launch 模型可能会触发该错误日志.

During worker startup and receive launch_builtin_model concurrently, there were error log:

2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR Connected to supervisor as a fresh worker
2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR [request 4578fdd8-5e5d-11ef-bddf-0ecc93937455] Enter launch_builtin_model, args: ...
2024-08-20 02:41:08,327 xinference.core.worker 7 ERROR report_event error: 'WorkerActor' object has no attribute '_event_collector_ref
@XprobeBot XprobeBot added the bug Something isn't working label Aug 20, 2024
@XprobeBot XprobeBot added this to the v0.14 milestone Aug 20, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit b66c1d4 into xorbitsai:main Aug 23, 2024
12 of 13 checks passed
@frostyplanet frostyplanet deleted the fix_lazy branch September 5, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants