Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Support minicpm-4B #2263

Merged
merged 6 commits into from
Sep 10, 2024
Merged

FEAT: Support minicpm-4B #2263

merged 6 commits into from
Sep 10, 2024

Conversation

Jun-Howie
Copy link
Contributor

Testing has been done locally and the model requires the following two dependencies to be added - datamodel_code_generator and jsonschema

Support minicpm-4B
Support minicpm-4B
Support minicpm-4B
Support minicpm-4B
Support minicpm-4B
@XprobeBot XprobeBot added this to the v0.15 milestone Sep 9, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this model to

to support vllm?

.github/workflows/python.yaml Show resolved Hide resolved
@Jun-Howie
Copy link
Contributor Author

您能否将此模型添加到

支持 VLLM?

vllm is not officially supported yet,See the vllm branch maintained by minicpm

https://github.com/OpenBMB/vllm/tree/minicpm3
and
https://github.com/OpenBMB/vllm/blob/minicpm3/vllm/model_executor/models/minicpm3.py

@qinxuye qinxuye changed the title Support minicpm-4B FEAT: Support minicpm-4B Sep 10, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 3e57959 into xorbitsai:main Sep 10, 2024
12 of 13 checks passed
@linqingxu
Copy link

模型上线页面没有minicpm-4b模型

@Jun-Howie
Copy link
Contributor Author

模型上线页面没有minicpm-4b模型

您是pip 安装的的xinference把,这个支持目前还没推送到pip源上,要等周五晚上发版

@linqingxu
Copy link

模型上线页面没有minicpm-4b模型

您是pip 安装的的xinference把,这个支持目前还没推送到pip源上,要等周五晚上发版

是用docker部署的,昨天pull的nightly-main镜像里找不到minicpm3-4b

@Jun-Howie
Copy link
Contributor Author

模型上线页面没有minicpm-4b模型

您是pip 安装的的xinference把,这个支持目前还没推送到pip源上,要等周五晚上发版

是用docker部署的,昨天pull的nightly-main镜像里找不到minicpm3-4b

我拉了最新的nightly-main镜像 。是有这个模型的!

image

@linqingxu
Copy link

模型上线页面没有minicpm-4b模型

您是pip 安装的的xinference把,这个支持目前还没推送到pip源上,要等周五晚上发版

是用docker部署的,昨天pull的nightly-main镜像里找不到minicpm3-4b

我拉了最新的nightly-main镜像 。是有这个模型的!

image

又试了一次,现在有了,请问能支持vllm推理吗,我看minicpm是有支持vllm的(得安装他们的分支)

@Jun-Howie
Copy link
Contributor Author

模型上线页面没有minicpm-4b模型

您是pip 安装的的xinference把,这个支持目前还没推送到pip源上,要等周五晚上发版

是用docker部署的,昨天pull的nightly-main镜像里找不到minicpm3-4b

我拉了最新的nightly-main镜像 。是有这个模型的!
image

又试了一次,现在有了,请问能支持vllm推理吗,我看minicpm是有支持vllm的(得安装他们的分支)

目前mincpm的vllm分支还没有合并到vllm主分支上,(所有暂时还不支持)你可以根据minicpm的文档单独进行编译

@haoguangxie
Copy link

支持sglang推理吗?我看minicpm是有支持sglang的

@qinxuye
Copy link
Contributor

qinxuye commented Nov 5, 2024

sglang 添加模型只需要添加模型名到列表:

SGLANG_SUPPORTED_CHAT_MODELS = [

欢迎贡献 PR。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants