Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Pending queue for concurrent requests #2473

Merged
merged 8 commits into from
Oct 25, 2024
Merged

ENH: Pending queue for concurrent requests #2473

merged 8 commits into from
Oct 25, 2024

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Oct 22, 2024 •
edited by qinxuye
Loading

Fixes #2463 .

@XprobeBot XprobeBot added the enhancement New feature or request label Oct 22, 2024
@XprobeBot XprobeBot added this to the v0.15 milestone Oct 22, 2024
@codingl2k1 codingl2k1 changed the title ENH: Pending queue for concurent requests ENH: Pending queue for concurrent requests Oct 22, 2024
@codingl2k1 codingl2k1 marked this pull request as ready for review October 23, 2024 15:46
qinxuye
qinxuye approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
Copy link
Contributor

qinxuye commented Oct 25, 2024

I tested:

  1. For those cannot parallelize, this will not error again.
  2. For those can parallelize, it works as before.

@qinxuye qinxuye merged commit 804297f into xorbitsai:main Oct 25, 2024
13 checks passed
@qinxuye qinxuye mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.15
3 participants
@codingl2k1 @qinxuye @XprobeBot