Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix embedding model gte-Qwen2 dimensions #2479

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

JinCheng666
Copy link
Contributor

@JinCheng666 JinCheng666 commented Oct 24, 2024

fix embedding model gte-Qwen2 dimensions
@XprobeBot XprobeBot added this to the v0.15 milestone Oct 24, 2024
Copy link
Contributor Author

@JinCheng666 JinCheng666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@JinCheng666
Copy link
Contributor Author

I don't know if this PR conforms to the project rules, please point out if there is anything wrong

@qinxuye qinxuye changed the title fix embedding model gte-Qwen2 dimensions BUG: fix embedding model gte-Qwen2 dimensions Oct 24, 2024
@XprobeBot XprobeBot added the bug Something isn't working label Oct 24, 2024
@JinCheng666
Copy link
Contributor Author

i dont know why the python3.11 check fail. it seems like not problems with the code.
how to rerun the checks? @qinxuye

@qinxuye
Copy link
Contributor

qinxuye commented Oct 24, 2024

i dont know why the python3.11 check fail. it seems like not problems with the code. how to rerun the checks? @qinxuye

That's OK, can you run python doc/source/gen_docs.py?

This will change many files, you can revert others but the gte-qwen2.rst then commit.

https://github.com/xorbitsai/inference/blob/main/doc/source/models/builtin/embedding/gte-qwen2.rst

@JinCheng666
Copy link
Contributor Author

JinCheng666 commented Oct 24, 2024

i dont know why the python3.11 check fail. it seems like not problems with the code. how to rerun the checks? @qinxuye

That's OK, can you run python doc/source/gen_docs.py?

This will change many files, you can revert others but the gte-qwen2.rst then commit.

https://github.com/xorbitsai/inference/blob/main/doc/source/models/builtin/embedding/gte-qwen2.rst

I ran the code locally and got an error, so I manually adjusted the contents of the file, not sure if it was appropriate?

window pc,The error information is as follows:

PS D:\work\code\inference\doc\source> python .\gen_docs.py
Traceback (most recent call last):
  File "D:\work\code\inference\doc\source\gen_docs.py", line 284, in <module>
    main()
  File "D:\work\code\inference\doc\source\gen_docs.py", line 54, in main
    models = json.load(model_file)
  File "C:\Users\liujincheng\.conda\envs\openaitest\lib\json\__init__.py", line 293, in load
    return loads(fp.read(),
UnicodeDecodeError: 'gbk' codec can't decode byte 0x80 in position 7227: illegal multibyte sequence

@qinxuye
Copy link
Contributor

qinxuye commented Oct 24, 2024

i dont know why the python3.11 check fail. it seems like not problems with the code. how to rerun the checks? @qinxuye

That's OK, can you run python doc/source/gen_docs.py?
This will change many files, you can revert others but the gte-qwen2.rst then commit.
https://github.com/xorbitsai/inference/blob/main/doc/source/models/builtin/embedding/gte-qwen2.rst

I ran the code locally and got an error, so I manually adjusted the contents of the file, not sure if it was appropriate?

window pc,The error information is as follows:

PS D:\work\code\inference\doc\source> python .\gen_docs.py
Traceback (most recent call last):
  File "D:\work\code\inference\doc\source\gen_docs.py", line 284, in <module>
    main()
  File "D:\work\code\inference\doc\source\gen_docs.py", line 54, in main
    models = json.load(model_file)
  File "C:\Users\liujincheng\.conda\envs\openaitest\lib\json\__init__.py", line 293, in load
    return loads(fp.read(),
UnicodeDecodeError: 'gbk' codec can't decode byte 0x80 in position 7227: illegal multibyte sequence

Should be OK, let's wait for CI to complete.

@JinCheng666
Copy link
Contributor Author

i dont know why the python3.11 check fail. it seems like not problems with the code. how to rerun the checks? @qinxuye

That's OK, can you run python doc/source/gen_docs.py?
This will change many files, you can revert others but the gte-qwen2.rst then commit.
https://github.com/xorbitsai/inference/blob/main/doc/source/models/builtin/embedding/gte-qwen2.rst

I ran the code locally and got an error, so I manually adjusted the contents of the file, not sure if it was appropriate?
window pc,The error information is as follows:

PS D:\work\code\inference\doc\source> python .\gen_docs.py
Traceback (most recent call last):
  File "D:\work\code\inference\doc\source\gen_docs.py", line 284, in <module>
    main()
  File "D:\work\code\inference\doc\source\gen_docs.py", line 54, in main
    models = json.load(model_file)
  File "C:\Users\liujincheng\.conda\envs\openaitest\lib\json\__init__.py", line 293, in load
    return loads(fp.read(),
UnicodeDecodeError: 'gbk' codec can't decode byte 0x80 in position 7227: illegal multibyte sequence

Should be OK, let's wait for CI to complete.

so cool, my first pr is coming soon...

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@qinxuye qinxuye merged commit 6fd879c into xorbitsai:main Oct 24, 2024
10 of 13 checks passed
@JinCheng666
Copy link
Contributor Author

LGTM, thanks for your contribution!

thank you vary much ! happy 1024 day! @qinxuye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gte-Qwen2 Incorrect model information / 模型信息有误
3 participants