Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix subprocess log on linux #357

Merged
merged 1 commit into from
Aug 30, 2023
Merged

BUG: fix subprocess log on linux #357

merged 1 commit into from
Aug 30, 2023

Conversation

UranusSeven
Copy link
Contributor

No description provided.

@XprobeBot XprobeBot added the bug Something isn't working label Aug 16, 2023
@XprobeBot XprobeBot added this to the v0.2.0 milestone Aug 16, 2023
@xorbitsai xorbitsai locked and limited conversation to collaborators Aug 16, 2023
@xorbitsai xorbitsai unlocked this conversation Aug 16, 2023
@XprobeBot XprobeBot modified the milestones: v0.2.0, v0.2.1 Aug 21, 2023
@aresnow1
Copy link
Contributor

Does it work?

@UranusSeven
Copy link
Contributor Author

The subprocess logging still doesn't work.

@aresnow1
Copy link
Contributor

It works on my machine for python 3.11, you can see different pid in logs:

2023-08-25 22:20:27,033 xinference.core.worker 1142182 DEBUG    Subpool selected: 127.0.0.1:41309, running model count: 0
launch done
2023-08-25 22:20:28,741 xinference.core.model 1142271 DEBUG    launch done===========================

aresnow1
aresnow1 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 4a23d57 into xorbitsai:main Aug 30, 2023
Bojun-Feng pushed a commit to Bojun-Feng/inference that referenced this pull request Aug 31, 2023
@UranusSeven @Bojun-Feng
BUG: fix subprocess log on linux (xorbitsai#357)
85e2d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnow1 aresnow1 aresnow1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@UranusSeven @aresnow1 @XprobeBot