-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EHN: auto retry download on network errors #405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayini1119
changed the title
EHN: Exception on Network Errors
EHN: Exception on Network Errors for Model Download
Aug 28, 2023
We should retry on LocalEntryNotFoundError. Catch the exception above and download again with same parameters should work. |
jiayini1119
changed the title
EHN: Exception on Network Errors for Model Download
EHN: auto retry download on network errors
Aug 28, 2023
UranusSeven
reviewed
Aug 28, 2023
UranusSeven
reviewed
Aug 28, 2023
UranusSeven
reviewed
Aug 28, 2023
UranusSeven
reviewed
Aug 30, 2023
UranusSeven
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #302.