Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: [UI] Upgrade insecure requests #722

Closed
wants to merge 2 commits into from
Closed

BUG: [UI] Upgrade insecure requests #722

wants to merge 2 commits into from

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Dec 5, 2023 •
edited
Loading

Fixes #639
Related #712 #716

@XprobeBot XprobeBot added the enhancement New feature or request label Dec 5, 2023
@XprobeBot XprobeBot added this to the v0.6.6 milestone Dec 5, 2023
@ChengjieLi28 ChengjieLi28 mentioned this pull request Dec 5, 2023
Merged
@ChengjieLi28 ChengjieLi28 changed the title ENH: [UI] Upgrade insecure requests BUG: [UI] Upgrade insecure requests Dec 5, 2023
@XprobeBot XprobeBot added bug Something isn't working and removed enhancement New feature or request labels Dec 5, 2023
@ChengjieLi28 ChengjieLi28 force-pushed the enh/securiry_request_fix branch from 1eed0b2 to 3599a26 Compare December 5, 2023 07:45
@ChengjieLi28
Copy link
Contributor Author

Hi, @waltcow .
We have reverted your PR #712 since if there is only http service, the UI would enconter an error.
Could you please help test this PR #722 in your environment? Thanks.

@aresnow1
Copy link
Contributor

aresnow1 commented Dec 6, 2023

@waltcow hi, could you test if this branch works well with https?

@waltcow
Copy link
Contributor

waltcow commented Dec 7, 2023

@aresnow1 @ChengjieLi28

browser security alert still exist

image

@ChengjieLi28
Copy link
Contributor Author

@aresnow1 @ChengjieLi28

browser security alert still exist

image

Thank you very much. I will fix soon.

@waltcow
Copy link
Contributor

waltcow commented Dec 7, 2023

image

@waltcow
Copy link
Contributor

waltcow commented Dec 7, 2023

image

@waltcow
Copy link
Contributor

waltcow commented Dec 7, 2023

I use traefik as gateway (add basic auth middleware) to forward request to my self-host instance

@ChengjieLi28 ChengjieLi28 force-pushed the enh/securiry_request_fix branch from 3599a26 to 651c321 Compare December 7, 2023 04:02
@ChengjieLi28
Copy link
Contributor Author

I use traefik as gateway (add basic auth middleware) to forward request to my self-host instance

I think you should add some configs on traefik to handle this issue. Refer to
image (https://www.hellosanta.com.tw/knowledge/category-38/post-193)

Could you please try this?

@waltcow
Copy link
Contributor

waltcow commented Dec 7, 2023

I

I use traefik as gateway (add basic auth middleware) to forward request to my self-host instance

I think you should add some configs on traefik to handle this issue. Refer to image (https://www.hellosanta.com.tw/knowledge/category-38/post-193)

Could you please try this?

image

it works, thanks

@aresnow1 aresnow1 mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

BUG: model is launched but can not find any items in UI
4 participants
@ChengjieLi28 @aresnow1 @waltcow @XprobeBot