Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs: Fixing issue with emote encoding in streaming chat, Fixing issue with missing pad_token for pytorch tokenizers, allowing system message as latest message in chat #747

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

AndiMajore
Copy link
Contributor

Collection of three small fixes for issues:

  • Streaming mode for chats broke emote encoding; fixed by trimming incomplete/non-decodable characters from chunk
  • Running llama models would throw missing pad_token errors: fixed by setting to eos_token
  • Ran into issue when initializing behavior by sending system message only: allowing system or user messages to be latest message

@XprobeBot XprobeBot added this to the v0.7.1 milestone Dec 8, 2023
@aresnow1
Copy link
Contributor

aresnow1 commented Dec 12, 2023

Could you provide a minimal reproduction for the first issue?

I've reproduced and tested on this branch, thanks for your contributions!

@aresnow1 aresnow1 merged commit d4aa287 into xorbitsai:main Dec 12, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants