-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Simple OAuth2 system #793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengjieLi28
force-pushed
the
feat/oauth
branch
from
December 21, 2023 09:25
af14eb4
to
b29f16b
Compare
ChengjieLi28
force-pushed
the
feat/oauth
branch
3 times, most recently
from
December 25, 2023 06:18
c477e3c
to
b880f4b
Compare
ChengjieLi28
changed the title
[WIP] FEAT: Simple OAuth2 system
FEAT: Simple OAuth2 system
Dec 25, 2023
ChengjieLi28
force-pushed
the
feat/oauth
branch
3 times, most recently
from
December 28, 2023 09:38
b489ff4
to
7734e95
Compare
ChengjieLi28
force-pushed
the
feat/oauth
branch
3 times, most recently
from
January 3, 2024 04:41
ccc8998
to
10c42f1
Compare
codingl2k1
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ChengjieLi28
force-pushed
the
feat/oauth
branch
from
January 9, 2024 06:57
051728b
to
f58a39a
Compare
ChengjieLi28
commented
Jan 10, 2024
Co-authored-by: Chengjie Li <109656400+ChengjieLi28@users.noreply.github.com>
aresnow1
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698
Detail
--auth-config
option forxinference-local
andxinference-supervisor
command for startup xinference with auth system.Firstly, a login web page for sign in when the user tries to open the web UI. Then use the web as before. If user does not have the right permission, UI would show error.
Then use the command as before.