Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Simple OAuth2 system #793

Merged
merged 27 commits into from
Jan 10, 2024
Merged

FEAT: Simple OAuth2 system #793

merged 27 commits into from
Jan 10, 2024

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Dec 20, 2023

Fixes #698

image image

Detail

  1. add --auth-config option for xinference-local and xinference-supervisor command for startup xinference with auth system.
  2. Nothing changed when using xinference without auth.
  3. For web users:
    Firstly, a login web page for sign in when the user tries to open the web UI. Then use the web as before. If user does not have the right permission, UI would show error.
  4. For command line users, user should login first:
xinference login --username <name> --password <pass>

Then use the command as before.

  1. For SDK users, also login first:
from xinference.client import Client
client = Client('<endpoint>')
client.login('<name>', '<pass>')

@XprobeBot XprobeBot added this to the v0.7.3 milestone Dec 20, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.3, v0.7.4 Dec 22, 2023
@ChengjieLi28 ChengjieLi28 force-pushed the feat/oauth branch 3 times, most recently from c477e3c to b880f4b Compare December 25, 2023 06:18
@ChengjieLi28 ChengjieLi28 changed the title [WIP] FEAT: Simple OAuth2 system FEAT: Simple OAuth2 system Dec 25, 2023
@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review December 25, 2023 06:19
@XprobeBot XprobeBot modified the milestones: v0.7.4, Temp, v0.8.0 Dec 25, 2023
@ChengjieLi28 ChengjieLi28 force-pushed the feat/oauth branch 3 times, most recently from b489ff4 to 7734e95 Compare December 28, 2023 09:38
@XprobeBot XprobeBot modified the milestones: v0.7.4, v0.8.0 Dec 29, 2023
@ChengjieLi28 ChengjieLi28 force-pushed the feat/oauth branch 3 times, most recently from ccc8998 to 10c42f1 Compare January 3, 2024 04:41
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Chengjie Li <109656400+ChengjieLi28@users.noreply.github.com>
@aresnow1 aresnow1 merged commit d71ab53 into xorbitsai:main Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide some authentication mechanism for UI and API
4 participants