Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix typing_extension version problem in notebook #856

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

onesuper
Copy link
Contributor

@onesuper onesuper commented Jan 3, 2024

Only change one line

@XprobeBot XprobeBot added this to the v0.8.0 milestone Jan 3, 2024
@onesuper onesuper force-pushed the add_notebook_quick_start branch from b0035cb to 865951e Compare January 3, 2024 10:41
@onesuper onesuper requested a review from qinxuye January 3, 2024 10:43
@onesuper onesuper changed the title Add notebook quick start BUG: Fix typing_extension version problem in notebook Jan 3, 2024
@XprobeBot XprobeBot added the bug Something isn't working label Jan 3, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Jan 3, 2024

I think we can limit typing_extension version in setup.cfg at

typing_extensions

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 5d14340 into main Jan 3, 2024
21 of 22 checks passed
@qinxuye qinxuye deleted the add_notebook_quick_start branch January 3, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants