Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make the size param of *_to_image more compatible #881

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

liunux4odoo
Copy link
Contributor

the size param use '*' as seperator only. it should be better to support other characters such as 'x' or any other non-integers.

@XprobeBot XprobeBot added this to the v0.8.0 milestone Jan 11, 2024
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye changed the title make the size param of *_to_image more compatible ENH: make the size param of *_to_image more compatible Jan 11, 2024
@XprobeBot XprobeBot added the enhancement New feature or request label Jan 11, 2024
@codingl2k1 codingl2k1 merged commit 95bdf3b into xorbitsai:main Jan 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants